995358 - [Settings] Reorganize developer menu entries.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Jan Keromnes [:janx]]

Currently, the Developer menu is confusing and hard to use, and would greatly benefit from having its entries reorganized. Important entries like Remote Debugging should be made easier to reach, and similar entries (e.g. graphics-related) should be grouped together.

Comment 1

[Jan Keromnes [:janx]]

Attachment: github pull request

Comment 2

[Jan Keromnes [:janx]]

Attachment: developermenu.png

This is a screenshot of developer menu entries in their new order. (Sorry for the bad edit on "Developer HUD", I edited the screenshot to make it look more like bug #995124 sub-menus.)

Comment 3

[Jan Keromnes [:janx]]

Comment on attachment 8405666 [details]
developermenu.png

Omega, as mentioned in bug 995124, I'm trying to reorganize the developer menu entries in a way that makes more sense. Here is a screenshot of what I'm trying to achieve. Do you agree with these changes? If so, could you please include them in your Developer menu UX spec? Thanks!

P.S. That screenshot was badly edited to make the "Developer HUD" sub-menu look more like the sub-menu in your spec. In the future, I'll update the Settings App's CSS to make sub-menus look like your spec.

Comment 4

[Omega Feng [:Omega] [:馮於懋]]

Basically I think it's a good idea to regorgainze them, but I'm not sure whether it's well reorganized in your proposal since I'm not a dev. So I need feedback from another dev. here. Arthur, could you have some comments here?

Since we are refining the Developer menu now, I have one suggestion here:
There are some long strings here and cannot display completely, I need your help to make them shorter. I think all "Enable XXX [v]" can be just "XXX [v]", like:
"Enable hardware compo... [v]"  ->  "Hardware Composer [v]"

Comment 5

[Jan Keromnes [:janx]]

Comment on attachment 8405666 [details]
developermenu.png

(In reply to Omega Feng [:Omega] from comment #4)
> Basically I think it's a good idea to regorgainze them, but I'm not sure
> whether it's well reorganized in your proposal since I'm not a dev. So I
> need feedback from another dev. here. Arthur, could you have some comments
> here?

Also needinfoing Anthony who had some good suggestions earlier.

> Since we are refining the Developer menu now, I have one suggestion here:
> There are some long strings here and cannot display completely, I need your
> help to make them shorter. I think all "Enable XXX [v]" can be just "XXX
> [v]", like:
> "Enable hardware compo... [v]"  ->  "Hardware Composer [v]"

I already shortened a few strings, so I can do it further. Removing the "Enable"s makes sense, I'll do that.

Comment 6

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8405666 [details]
developermenu.png

Looks good to me, thanks!

Comment 7

[Omega Feng [:Omega] [:馮於懋]]

Hi Jan, how do you think where we should organize Update Channel and Update URL? (see spec in bug 995124)

Comment 8

[Jan Keromnes [:janx]]

Hi Omega, I think the way you did it in the spec makes sense, i.e. an "Update" category at the bottom of the Developer menu with two text inputs (the channel needs to be a text input and not an option selector because you might need to change it from e.g. "nightly" to more values like "mako/1.4.0/nightly").

However, I'll leave the update parameters out of the scope of this bug, which focuses on reorganizing just the current options in the menu, and will add the "Update" category in bug 984962.

Comment 9

[Jan Keromnes [:janx]]

Attachment: developermenu.png

New screenshot with shorter strings, Rik's and arthurcc's f+.

Comment 10

[Jan Keromnes [:janx]]

Comment on attachment 8405525 [details] [review]
github pull request

Vivien, this change simply reorganizes Developer menu items into categories that make more sense, and shortens the strings so that they fit on a small screen (at least in English).

For convenience, a screenshot shows the new look of the Developer menu. Please have a look :)

Comment 11

[Jan Keromnes [:janx]]

Comment on attachment 8405525 [details] [review]
github pull request

Actually Arthur, since you already gave feedback on the suggestion, maybe it makes more sense for you to review the code. Please have a look :)

Comment 12

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8405525 [details] [review]
github pull request

Thanks for the patch janx! As https://github.com/mozilla-b2g/gaia/commit/70e495701aeb8e99fa1f8191a4508ad9f86d804a has been landed, there are two conflicts due to it removed the labels containing the buttons. Please help resolve the conflicts and request the review when ready.

Comment 13

[Omega Feng [:Omega] [:馮於懋]]

See bug 995124 for the updated UX spec.

Comment 14

[Jan Keromnes [:janx]]

Comment on attachment 8405525 [details] [review]
github pull request

Hi Arthur, I rebased my commit to resolve the conflicts. Please have another look :)

Comment 15

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8405525 [details] [review]
github pull request

r=me, thank you!

Comment 16

[Jan Keromnes [:janx]]

Adding dev-doc-needed because this might invalidate a few screenshots of the developer menu.

Comment 17

[Jan Keromnes [:janx]]

Attachment: developermenu.png

(string "Remote debugging" changed to "Debugging via USB")

Comment 18

[Jan Keromnes [:janx]]

Attachment: developerhud.png

Reorganized Developer HUD